-
Notifications
You must be signed in to change notification settings - Fork 4
Handle coils in importOSMEdges and exportEdges
#272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 90.77% 90.62% -0.16%
==========================================
Files 36 36
Lines 5085 5108 +23
Branches 463 467 +4
==========================================
+ Hits 4616 4629 +13
- Misses 469 479 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| std::istringstream iss{line}; | ||
| std::string sourceId, targetId, length, lanes, highway, maxspeed, name, geometry; | ||
| // u;v;length;highway;maxspeed;name;geometry | ||
| std::string sourceId, targetId, length, lanes, highway, maxspeed, name, geometry, |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule Note
| for (auto const& [streetId, pStreet] : m_edges) { | ||
| file << streetId << ';' << pStreet->source() << ';' << pStreet->target() << ';' | ||
| << pStreet->name() << ';'; | ||
| if (pStreet->isSpire()) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 14.4 rule Note
| } else { | ||
| file << "Nan;Nan"; | ||
| } | ||
| if (pNode->isTrafficLight()) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 14.4 rule Note
| } | ||
| if (pNode->isTrafficLight()) { | ||
| file << ";traffic_light"; | ||
| } else if (pNode->isRoundabout()) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 14.4 rule Note
| } | ||
| std::istringstream iss{line}; | ||
| std::string nodeId, lat, lon; | ||
| std::string nodeId, lat, lon, type; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.3 rule Note
| auto const& it{m_nodes.find(std::stoul(nodeId))}; | ||
| if (it != m_nodes.cend()) { | ||
| it->second->setCoords(std::make_pair(dLat, dLon)); | ||
| if (type == "traffic_light" && !it->second->isTrafficLight()) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.1 rule Note
| if (it != m_nodes.cend()) { | ||
| it->second->setCoords(std::make_pair(dLat, dLon)); | ||
| if (type == "traffic_light" && !it->second->isTrafficLight()) { | ||
| makeTrafficLight(it->first, 60); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note
| it->second->setCoords(std::make_pair(dLat, dLon)); | ||
| if (type == "traffic_light" && !it->second->isTrafficLight()) { | ||
| makeTrafficLight(it->first, 60); | ||
| } else if (type == "roundabout" && !it->second->isRoundabout()) { |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 12.1 rule Note
| if (type == "traffic_light" && !it->second->isTrafficLight()) { | ||
| makeTrafficLight(it->first, 60); | ||
| } else if (type == "roundabout" && !it->second->isRoundabout()) { | ||
| makeRoundabout(it->first); |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 17.7 rule Note
| makeTrafficLight(it->first, 60); | ||
| } else if (type == "roundabout" && !it->second->isRoundabout()) { | ||
| makeRoundabout(it->first); | ||
| } |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 15.7 rule Note
No description provided.